Remove "new-style" haskell_import and related code #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mechanism was introduced in #442 and was meant to be a stepping stone towards removing the special treatment of prebuilt dependencies. It was plagued by performance problems related to Nix and never saw adoption beyond this project's test suite. With the advent of `stack_install` and `haskell_cabal_library`, we can finally get rid of it.
Was used by `haskell_import_new`, but useless now
thufschmitt
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mechanism was introduced in #442 and was meant to be a stepping
stone towards removing the special treatment of prebuilt dependencies.
It was plagued by performance problems related to Nix and never saw
adoption beyond this project's test suite. With the advent of
stack_installandhaskell_cabal_library, we can finally get rid ofit.