Skip to content

Fix darwin bindist by touching WORKSPACE file #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2019
Merged

Fix darwin bindist by touching WORKSPACE file #893

merged 1 commit into from
May 24, 2019

Conversation

Profpatsch
Copy link
Contributor

Closes: #884

@Profpatsch Profpatsch requested a review from mboes May 23, 2019 15:36
@Profpatsch Profpatsch mentioned this pull request May 23, 2019
Closed
@mboes mboes merged commit 607494e into master May 24, 2019
@mboes mboes deleted the fix-darwin-bindist-WORKSPACE branch May 24, 2019 08:59
@mboes
Copy link
Member

mboes commented May 24, 2019

How does this work?

@Profpatsch Profpatsch mentioned this pull request Jun 3, 2019
Merged
@Profpatsch
Copy link
Contributor Author

How does this work?

Some rule tried to access io_tweag_rules_haskel_ghc_darwin_amd64 as a bazel repository, but without a WORKSPACE file things are not counted as repository. If we touch it, it’s recognized as a repository. I am not 100% certain it should be counted as a repository, so please stop me if that’s wrong.

@mboes
Copy link
Member

mboes commented Jul 8, 2019

This looks suspicious to me. Are you sure it works with this patch but fails without? Also, Bazel tends to automatically generate a WORKSPACE file for external repositories.

@Profpatsch
Copy link
Contributor Author

I’ll try what happens if I remove this patch (once I can access the test Macbook again)

@mboes
Copy link
Member

mboes commented Jul 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboes mboes mboes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not build projects on MacOS Mojave
2 participants
@Profpatsch @mboes