Separate list_exposed_modules from compile_library #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are two completely separate steps. Furthermore, only the non-profiled version would actually perform list_exposed_modules.
aherrmann
force-pushed
the
list_exposed_modules
branch
from
749968c to
3647732
Compare
The resulting file was never used
mboes
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
compile_librarycontained a conditional step to list all exposed modules, but only ifwith_profilingwasFalse. This step is not strictly related tocompile_libraryand the step being conditional meant that the function potentially returned aNonevalue which was error prone. This PR separateslist_exposed_modulesinto its own step.