Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't import boot packages from nixpkgs #623

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Don't import boot packages from nixpkgs #623

merged 1 commit into from
Jan 23, 2019

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Jan 23, 2019 •
edited
Loading

Fixes #615

thufschmitt
thufschmitt approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check that you effectively replace all the needed occurences of @hackage//:, but later windows testing will catch the missing one anyways if needed, so 👍

@mboes mboes merged commit 869d14b into master Jan 23, 2019
@mboes mboes deleted the nm-pkg-boot-2 branch January 23, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboes mboes mboes approved these changes

@thufschmitt thufschmitt thufschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmattia @mboes @thufschmitt