CPP macro are only generated when 'version' attribute is specified. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibou
force-pushed
the
guibou/version-macro
branch
2 times, most recently
from
ac1c814
to
6bbb1d0
Compare
guibou
requested review from
mboes and
mrkkrp
and removed request for
mboes
guibou
commented
Sep 25, 2018
haskell/private/packages.bzl
Outdated
| "-fno-version-macros", | ||
| ]) | ||
|
|
||
| # Expose all prebuilt dependencies |
There was a problem hiding this comment.
This should not be indented, that's buildifier fault ;(
|
#445 was merged, and this PR works perfectly on a client huge codebase. |
guibou
force-pushed
the
guibou/version-macro
branch
from
6bbb1d0
to
89027de
Compare
guibou
force-pushed
the
guibou/version-macro
branch
3 times, most recently
from
9476a53
to
9e6488c
Compare
guibou
force-pushed
the
guibou/version-macro
branch
from
9e6488c
to
e265e9d
Compare
|
@mrkkrp @Profpatsch @mboes ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #414.
In #414, we observed that CPP version macro generated by GHC can leads to conflict if two bazel targets have the same name, hence the same GHC package name. For example
//foo:barand//frob:barwill have package namebarand will generatedVERSION_barmacros.This PR deactivate macro generation if rule does not have a
versionattribute. see #414 for discussion.