Refactor package configuration parsing in ls_modules and pkgdb_to_bzl#1457
Merged
mergify[bot] merged 3 commits intomasterfrom Jan 5, 2021
Merged
Refactor package configuration parsing in ls_modules and pkgdb_to_bzl#1457mergify[bot] merged 3 commits intomasterfrom
mergify[bot] merged 3 commits intomasterfrom
Conversation
mboes
approved these changes
Jan 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1453
Closes #1396
The package configuration parsing code in
ls_modulesdid not handle line wrapped fields correctly. As pointed out in #1169 (comment) we already have code handling wrapped fields inpkgdb_to_bzl.py. This PR factors this code out into a standalone Python module and uses that same module for package configuration parsing in bothls_modulesandpkgdb_to_bzl.py. The former is a regularpy_binarytarget, i.e. the library dependency is handled by Bazel. The latter is executed in a repository rule by invoking the Python interpreter directly. In that case the module import works because thepackage_configuration.pymodule is placed in the same directory aspkgdb_to_bzl.py.This PR also adds a Python test suite for the new Python module. This includes a regression test for #1453 .