Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell.nix should suggest adding host_platform to all (more?) commands, not just test #939

Closed
ulysses4ever opened this issue Jun 12, 2019 · 2 comments
Closed

shell.nix should suggest adding host_platform to all (more?) commands, not just test #939

ulysses4ever opened this issue Jun 12, 2019 · 2 comments
Labels
type: feature request

Comments

@ulysses4ever
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
shell.nix suggests adding .bazelrc.local with the following:

test --host_platform=@io_tweag_rules_haskell//haskell/platforms:''${ARCH}_x86_64_nixpkgs

But host_platform is needed to other commands, it seems. E.g. to build tutorial, which fails without it.

Describe the solution you'd like
shell.nix's suggestion should extend to more commands. common might be the right replacement for test.
@Profpatsch
Copy link
Contributor

We have a symlink of .bazelrc(.local) from both the tutorial and example subfolders, linking back to the ones in the project root. So changing it in the project root automatically copies over to these sub-workspaces.

Profpatsch added a commit that referenced this issue Jun 12, 2019
@Profpatsch
shell.nix: Improve the host_platform hint
768be1f 
`test` affects only the `test` subcommand of bazel, while `common`
affects all subcommands.

Closes: #939
Profpatsch added a commit that referenced this issue Jun 12, 2019
@Profpatsch
shell.nix: Improve the host_platform hint
bf76c1a 
`test` affects only the `test` subcommand of bazel, while `build`
affects `build` and `test` and `run` affects `run`, according to
https://docs.bazel.build/versions/master/guide.html#bazelrc-syntax-and-semantics

Closes: #939
@franckrasolo franckrasolo mentioned this issue Jun 13, 2019
Closed
@mboes
Copy link
Member

mboes commented Aug 12, 2019 •
edited
Loading

Closed by #941 , as the commit message in that message says. Issue auto-close doesn't seem to be working anymore. Could this be related to our use of Mergify?

@mboes mboes closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mboes @Profpatsch @ulysses4ever