Skip to content

Commit

Permalink
Apply 8.6.4 patch to 8.6.5 GHC Windows bindist as well.
Browse files Browse the repository at this point in the history
It seems that even at the 5th point release, GHC still has packaging
bugs on Windows.
  • Loading branch information
mboes committed May 23, 2019
1 parent 3305999 commit f04cd5f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
11 changes: 11 additions & 0 deletions haskell/assets/ghc_8_6_5_win_base.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
--- lib/package.conf.d/base-4.12.0.0.conf 2019-03-20 12:24:30.857292020 +0100
+++ lib/package.conf.d/base-4.12.0.0.conf 2019-03-20 12:24:44.637400564 +0100
@@ -79,7 +79,7 @@
data-dir: $topdir\x86_64-windows-ghc-8.6.5\base-4.12.0.0
hs-libraries: HSbase-4.12.0.0
extra-libraries:
- wsock32 user32 shell32 msvcrt mingw32 mingwex
+ wsock32 user32 shell32 msvcrt mingw32 mingwex shlwapi
include-dirs: $topdir\base-4.12.0.0\include
includes:
HsBase.h
1 change: 1 addition & 0 deletions haskell/ghc_bindist.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ def ghc_bindist(
patches = {
"8.6.2": ["@io_tweag_rules_haskell//haskell:assets/ghc_8_6_2_win_base.patch"],
"8.6.4": ["@io_tweag_rules_haskell//haskell:assets/ghc_8_6_4_win_base.patch"],
"8.6.5": ["@io_tweag_rules_haskell//haskell:assets/ghc_8_6_5_win_base.patch"],
}.get(version) if target == "windows_amd64" else None

extra_attrs = {"patches": patches, "patch_args": ["-p0"]} if patches else {}
Expand Down

0 comments on commit f04cd5f

Please sign in to comment.