Materialize buildOpamMonorepo#149
Merged
Merged
Conversation
Collaborator
|
Seems fine overall. Have you tested it? |
balsoft
requested changes
Jan 28, 2026
Collaborator
balsoft
left a comment
balsoft
left a comment
There was a problem hiding this comment.
I have looked at the packaging you are doing with this (ngi-nix/ngipkgs#2018), it seems to build and it looks OK to me as well.
So everything looks good, the only thing left is to please add the docs to DOCUMENTATION.md.
ju1m
force-pushed
the
materialize-monorepo
branch
from
2427a93 to
6a59579
Compare
balsoft
requested changes
Feb 4, 2026
ju1m
force-pushed
the
materialize-monorepo
branch
from
6a59579 to
963f498
Compare
Collaborator
|
Thanks! |
ju1m
pushed a commit
to ju1m/ngipkgs
that referenced
this pull request
Feb 16, 2026
4 tasks
ju1m
pushed a commit
to ju1m/ngipkgs
that referenced
this pull request
Feb 23, 2026
ju1m
pushed a commit
to ju1m/ngipkgs
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces materialized counter-parts to:
queryToMonorepobuildOpamMonoreponamed:
materializeQueryToMonorepomaterializeBuildOpamMonorepounmaterializeQueryToMonorepoIt enables to package MirageOS unikernels without IFD (ie. with
--option allow-import-from-derivation false).I came up with those copying as best as I could what was already done in
opam-nixto materializequeryToScopeandbuildOpamProjectinmaterialize,materializeOpamProject,materializedDefsToScope.But I'm new to
opam-nixand do not have much understanding of every details or the big picture, I just needed an IFD-free version of a MirageOS project in NGIpkgs (DNSvizor) and followed whathillingardid, replacing everything I needed to avoid IFD.So I may have made obvious mistakes.