Merge lazy array contracts #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fuzzypixelz maybe you've noticed, but there are conflicts to solve before being able to give it a review. |
fuzzypixelz
force-pushed
the
topic/lazy-array-contracts
branch
2 times, most recently
from
c8fbbf6
to
1a6c34c
Compare
fuzzypixelz
force-pushed
the
topic/lazy-array-contracts
branch
from
1a6c34c
to
589f700
Compare
yannham
approved these changes
Sep 6, 2022
src/interner.rs
Outdated
| //! # The [`Interner`] structure. | ||
| //! | ||
| //! To achive deduplication, we can use a [`HashSet`] of `Symbol` handles. Then, every time | ||
| //! we try to intern a new string, we can check |
yannham
force-pushed
the
topic/lazy-array-contracts
branch
from
589f700
to
8286782
Compare
Co-authored-by: Yann Hamdaoui <[email protected]>
Co-authored-by: Yann Hamdaoui <[email protected]>
Co-authored-by: Yann Hamdaoui <[email protected]>
Co-authored-by: Yann Hamdaoui <[email protected]>
Co-authored-by: Yann Hamdaoui <[email protected]>
Co-authored-by: Yann Hamdaoui <[email protected]>
Co-authored-by: Yann Hamdaoui <[email protected]>
Co-authored-by: Yann Hamdaoui <[email protected]>
yannham
force-pushed
the
topic/lazy-array-contracts
branch
from
8286782
to
d8e2071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the time the
topic/lazy-array-contractsbranch was finalized, master has diverged quite a bit and it's time merge it in finally.Let's also use this chance to pick up on any issues that might've been missed before.