Add --version support to NLS and fix feature unification issues #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `--version` support for the nls binary, using the same scheme as for the main `nickel` binary. Doing so, we discovered some underlying feature unification issues that weren't visible before - but were already there -, namely that the little stunt we pull off for generating versions in different environment (in the git repo, building for crates.io and the nixified version) requires the `string` feature of clap. It just happened that it was enabled previously for `nickel-lang-cli` by chance by feature unification (through `comrak`), but in fact building `nickel-lang-cli` without the default features was failing. This commit fixes the compilation issue by adding the missing `string` feature to the `clap` dependency for both the cli and the lsp. `nickel-lang-lsp` also depends on `nickel-lang-core` without the default features now (as most of them are useless for the LSP), and we fix the another compilation error of `nickel-lang-cli` without default features by making `nickel-lang-core` always export `eval_record_spine`, which would only be included when the `doc` feature was enabled before, but is actually used for other purposes now (namely the CLI customize mode).
jneem
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--versionsupport for thenlsbinary, using the same scheme as for the mainnickelbinary. Its absence made it hard to know which version of NLS users would currently run, which isn't great for chasing bugs.Doing so, I discovered some underlying feature unification issues that were here but just invisible, namely that the little stunt we pull off for generating versions in different environments (in the git repo, building for crates.io and the nixified version) requires the
stringfeature of clap, but we didn't enable this feature explicitly anywhere. It just happened that it was enabled previously fornickel-lang-cliby chance, thanks to feature unification (throughcomrakwhich is used for thedocfeature). In fact buildingnickel-lang-cliwithout the default features is failing on current master, because the absence ofdocdoesn't pullcomrakin, which doesn't enable thestringfeature.This PR fixes the compilation issue by adding the missing
stringfeature to theclapdependency for both the cli and the lsp. We also makenickel-lang-lspalso depend onnickel-lang-corewithout the default featurs (as most of them are useless for the LSP), and we fix another unrelated compilation error ofnickel-lang-cliwithout default features by makingnickel-lang-corealways exporteval_record_spine, which would only be included when thedocfeature was enabled before, but is actually used for other purposes now (namely the CLI customize mode).