fixed std.array.split_at behavior at right boundary. #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkleen
requested changes
Feb 6, 2024
vkleen
approved these changes
Feb 6, 2024
yannham
reviewed
Feb 6, 2024
|
@suimong could you please rebase on latest master? This should solve the (unrelated) CI issue. |
suimong
force-pushed
the
fix_std_array_split_at
branch
from
8172358
to
5a10769
Compare
|
Not sure why the two tests failed. I'll look into it tomorrow. |
|
I think it's just outdated snapshots for the snapshot tests, you should be able to see them fail locally with |
|
I see. Will do that tomorrow morning. |
suimong
force-pushed
the
fix_std_array_split_at
branch
from
5a10769
to
d81eb7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1802 .