-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed std.array.split_at behavior at right boundary. #1803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The CI seems to be broken because of an unrelated problem. Thanks a lot for finding and fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good.
@suimong could you please rebase on latest master? This should solve the (unrelated) CI issue. |
8172358
to
5a10769
Compare
Not sure why the two tests failed. I'll look into it tomorrow. |
I think it's just outdated snapshots for the snapshot tests, you should be able to see them fail locally with |
I see. Will do that tomorrow morning. |
5a10769
to
d81eb7a
Compare
fixes #1802 .