Nls import improvements #1795
Merged
Nls import improvements #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already tracking import dependencies for cache invalidation, but only for imports that exist. Here, we add support for imports that fail because of I/O errors: we remember the filename of the failed import, and whenever nls becomes aware of a new file with that name, it invalidates the importers.
yannham
approved these changes
Jan 31, 2024
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for NICKEL_IMPORT_PATH to nls. Fixes #1786.
Based on the discussion here I also looked into absolute paths. As far as I could tell, they work. But I ran into an issue when testing them: if you write
"import foo.ncl"for a file that doesn't exist, nls will correctly flag it. If you then create that file, nls won't notice until you restart it. This PR fixed the issue as long as you open and/or create the missing import in your editor. (We aren't watching the filesystem for changes)Depends on #1794.