First prototype of evaluation #1672
Conversation
lsp/nls/src/command.rs
Outdated
|
|
||
| fn eval(server: &mut Server, uri: &Url) -> Result<(), Error> { | ||
| if let Some(file_id) = server.cache.file_id(uri)? { | ||
| // TODO: avoid cloning the cache. Maybe we can have a VM with a &mut ImportResolver? |
There was a problem hiding this comment.
Hmm, this would be annoying because we'd have to add a lifetime parameter to VirtualMachine. I wonder if you can't just implement ImportResolver for &'a mut R when R: ImportResolver, thus passing a mutable reference instead? Or just wrap it as a dedicated type ImportResolverRef<'a, R: ImportResolver>(&'a mut ImportResolver) and implement the trait. After all VirtualMachine is generic over the resolver.
There was a problem hiding this comment.
Oh, that's a good point. I'll give it a quick try, and if it works I'll add it to this PR
There was a problem hiding this comment.
Implementing ImportResolver for &'a mut R worked nicely, but it didn't solve the issue because prepare_eval is only defined when the import resolver parameter is ImportCache. I'll just leave the TODO for now...
This is an initial (and pretty dumb) version of evaluation: there's a code action that evaluates the whole file (from scratch every time you ask for it) and presents the diagnostics.
Fixes #1639