Remove/rename the Linearizer trait #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Nitpick: it's a bit confusing to call something TypeVisitor while it's actually visiting terms (because XXXVisitor is usually used for the visitor trait of XXX). Possible suggestions:
- just call it
TermVisitor - call it
TypecheckVisitoror something like that where the first word isn't a datastructure which could have a visitor trait
|
I went with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames Linearizer to TypeVisitor and simplifies the interface. (The interface may even be too simple now, but it's what
nlscurrently wants.)