Nuke the linearizer #1658
Merged
Nuke the linearizer #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
The diff feels good 👍 great job going all the way through getting rid of the linearizer, @jneem ! This doesn't have to be in this PR but I always found linearizer to be a bad name; Maybe we should also rename nickel_lang::typecheck::linearizer stuff as well? Could be something about Visitor (because it's mostly a visitor pattern from the typechecker enriched with additional type infos), or something around code analyzer.
|
Good point, I'd renamed the linearizer stuff in nls but forgot about nickel_lang_core. I'll do that in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit of refactoring/renaming, and a lot of deletion.