Disable the colors when stdout isn't a tty #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkleen
reviewed
Aug 7, 2023
|
FYI, clippy is complaining. As a oneliner, you can run: cargo clippy --all-targets --workspace -- --deny warnings --allow clippy::new-without-default --allow clippy::match_like_matches_macroto reproduce what the CI is doing. We discussed just today that the developer environment didn't give proper access to clippy, because it's not in the pre-commit hooks anymore 😅 that should be fixed, but in the meantime, this is the script I use |
thufschmitt
force-pushed
the
no-color-if-no-tty
branch
from
e774381
to
4ba213b
Compare
|
Fixed the clippy warning, and made the test actually test something (by grepping for the correct string and in the right stream). Should be much better now |
vkleen
approved these changes
Aug 8, 2023
yannham
approved these changes
Aug 8, 2023
thufschmitt
force-pushed
the
no-color-if-no-tty
branch
from
4ba213b
to
ae102c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1500
The test is probably wrong. I'll try and make it correct, but if there's a better way of writing it, please let me know.