-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add %eval_nix% primop #1465
add %eval_nix% primop #1465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can make the flake outputs more configurable to avoid the heavy dependency footprint in e.g. nix run github:tweag/nickel
if one is just looking for a minimal Nickel interpreter. But that's probably better tackled in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The footprint isn't as bad as I thought (it doesn't add to much nix-experimental-related code).
@Radvendii is there anything left to do to merge this PR (beside rebasing, now there's a conflict)? I fear this drifts further away from master |
There's a phantom bug which only occurs in CI, Not even on my local x86_64-darwin machine which is using the same version of I tried to track down the phantom bug using valgrind, but the nix package for valgrind is broken, and when I used an old version it didn't actually work. It seems from internet searches that valgrind is just kind of broken on mac os? Given that this is only a problem with a single test, I've filed the bug with upstream and disabled tests for now. |
add an %eval_nix% primop which calls out to the nix C++ bindings. At the moment, this goes through JSON and therefore requires the nix to fully evaluate
Partly addresses #1431