Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework and simplify the Nix + Stack infrastructure #194

Closed
wants to merge 3 commits into from
Closed

Rework and simplify the Nix + Stack infrastructure #194

wants to merge 3 commits into from

Conversation

sir4ur0n
Copy link
Contributor

@sir4ur0n sir4ur0n commented Oct 21, 2021 •
edited
Loading

⚠️ This is a Work In Progress!

  • Implement materialization to decrease further evaluation times
  • Check that tutorial building/running still works (probably requires some extra work regarding Jupyter/etc.)
  • Check if there's any impact for the cookiecutter template
  • Optional: investigate flakiness of funflow/test/flows/TestFunflow.hs last test (sometimes hangs, does not seem related to this PR, could be addressed in separate issue)
  • Add to buildInputs, use and document nixpkgs-fmt

@sir4ur0n sir4ur0n mentioned this pull request Oct 21, 2021
Open
@sir4ur0n sir4ur0n marked this pull request as draft October 21, 2021 10:29
@sir4ur0n sir4ur0n changed the title WIP: Rework and simplify the Nix + Stack infrastructure Rework and simplify the Nix + Stack infrastructure Oct 21, 2021
@sir4ur0n sir4ur0n self-assigned this Oct 21, 2021
@sir4ur0n
Copy link
Contributor Author

Closing this PR in favor of #196

@sir4ur0n sir4ur0n closed this Oct 27, 2021
@sir4ur0n sir4ur0n deleted the sir4ur0n/reworkNix branch October 27, 2021 07:41
@GuillaumeDesforges
Copy link
Contributor

Very nice work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sir4ur0n sir4ur0n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sir4ur0n @GuillaumeDesforges