docs: require explicit sign-off before adding new public API surface - #447
Merged
Conversation
EnablePackageValidation only catches breaking removals/signature changes against the baseline - it has nothing to say about new public members, so a new public type/method/property can ship with zero automated pushback. Both IMetadataLoader/MetadataManager.SetMetadataLoader and PhoneNumberUtil.PrewarmRegionsAsync were added this way, each justified in the moment by "matches an existing precedent" reasoning, and both are now being reconsidered as possibly unwarranted API-surface growth that can only be removed as a breaking change. Adding new public API surface should get the same explicit-decision treatment as removing it, not ride along as a side effect of an unrelated task's own justification. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVGRJyQwtvBGXAmWswxyqW
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
=======================================
Coverage 87.26% 87.26%
=======================================
Files 41 41
Lines 3831 3831
Branches 978 978
=======================================
Hits 3343 3343
Misses 284 284
Partials 204 204 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Extensions exists specifically to grow with C#-idiomatic helpers beyond Java's API surface - that's its whole purpose, unlike the main library which tracks Java's API shape closely. The break-glass concern is about unplanned deviation from Java parity in the core port, not about the package that's explicitly meant to add things Java doesn't have. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVGRJyQwtvBGXAmWswxyqW
wmundev
approved these changes
Aug 31, 2026
This was referenced Sep 10, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnablePackageValidationonly catches breaking removals/signature changes against the baseline — it has nothing to say about new public members, so a new public type/method/property can ship with zero automated pushback. BothIMetadataLoader/MetadataManager.SetMetadataLoaderandPhoneNumberUtil.PrewarmRegionsAsyncwere added this way — each justified in the moment by "matches an existing precedent" reasoning — and both are now being reconsidered as possibly-unwarranted API-surface growth that, having shipped, can now only be walked back as a breaking change.Adds one line to
CLAUDE.md: adding new public API surface toPhoneNumbersgets the same explicit-decision treatment as removing it — it should never ride along as a side effect of an unrelated task's own justification, no matter how well it matches an existing pattern.