Skip to content

style: idiomatic cleanups in matcher/formatter/filter test suites #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twcclegg merged 1 commit into from
Aug 26, 2026
Merged

style: idiomatic cleanups in matcher/formatter/filter test suites #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions csharp/PhoneNumbers.Test/TestPhoneNumberMatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,12 +665,12 @@ private void DoTestNumberMatchesForLeniency(List<NumberTest> testCases,
var iterator =
FindNumbersForLeniency(test.RawString, test.Region, leniency);
var match = iterator.FirstOrDefault();
if (match == null)
if (match is null)
{
noMatchFoundCount++;
Console.WriteLine("No match found in " + test + " for leniency: " + leniency);
}
else if (!test.RawString.Equals(match.RawString))
else if (test.RawString != match.RawString)
{
wrongMatchFoundCount++;
Console.WriteLine("Found wrong match in test " + test +
Expand All @@ -691,7 +691,7 @@ private void DoTestNumberNonMatchesForLeniency(List<NumberTest> testCases,
var iterator =
FindNumbersForLeniency(test.RawString, test.Region, leniency);
var match = iterator.FirstOrDefault();
if (match != null)
if (match is not null)
{
matchFoundCount++;
Console.WriteLine("Match found in " + test + " for leniency: " + leniency);
Expand Down