Skip to content

docs: reconcile stale Todo sections with current state #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twcclegg merged 1 commit into from
Aug 24, 2026
Merged

docs: reconcile stale Todo sections with current state #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,16 +169,6 @@ Therefore, we recommend you keep this nuget package as up to date as possible us

For more information on metadata usage, please refer to the [main repository faq](https://github.com/google/libphonenumber/blob/master/FAQ.md#metadata)

## ToDo

* update / add / port new unit tests and logging from java source

## How to unfold automatic generated files

* Install Jetbrains - Resharper for Visual Studio
* File by file, right click and "Cleanup code"
* Check the unfolded file

## Running tests locally

```bash
Expand Down
12 changes: 6 additions & 6 deletions csharp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ Known Issues
and embedded in the assembly. No zip files or text files are needed to run the library or its
tests.


Todo
----

- Restore the Java logging calls?
- Find a suitable replace for Java CharSequence in phone numbers parsing API.
- Java's public API accepts `CharSequence` in several entry points (e.g.
`PhoneNumberMatcher`'s constructor, `isViablePhoneNumber`), letting callers pass a `String`,
`StringBuilder`, or `StringBuffer` without copying. The C# port takes `string` in the
equivalent spots (`PhoneNumberMatcher(PhoneNumberUtil, string, ...)`,
`PhoneNumberUtil.IsViablePhoneNumber(string)`) instead of a comparable abstraction, so a
caller building up a number in a `StringBuilder` has to call `.ToString()` first.