Close the Scorecard token-permission and unpinned-restore findings - #387
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 39 39
Lines 52854 52854
Branches 1119 1119
=======================================
Hits 51803 51803
Misses 796 796
Partials 255 255 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 28, 2026
Closed
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two actionable OpenSSF Scorecard findings (score is 7.3 as of today).
Token-Permissions 0/10 — three warnings, all structural rather than actual over-grant:
codeql.ymlhad no top-levelpermissions:block, so the file defaulted to whatever the repodefault is. Now pinned to
contents: read; the job's own block is unchanged.create_new_release_on_new_metadata_update.ymldeclaredcontents: write+actions: writeatfile level. Both moved to the job, so a workflow-wide write token is never minted. Same
effective grant, same comment explaining why the writes are needed.
post_performance_test_comment.ymlanddeploy-demo.ymlalso carry top-level writes but were notflagged — Scorecard only treats contents/actions/packages writes as high severity, and both of
those files have a single job, so moving them would change nothing. Left alone.
Pinned-Dependencies 8/10 — "1 of 3 nugetCommand dependencies pinned". Adds
--locked-modetothe demo and publish restores, matching what the unit-test workflow already does. All eight
projects have a committed
packages.lock.json, so this is enforcement, not new policy. It mattersmost in
publish_nuget.yml, which is the restore whose output ships.Branch-Protection −1 — the default
GITHUB_TOKENcannot read classic branch-protection rules.Wires
repo_tokento aSCORECARD_TOKENsecret, falling back togithub.tokenwhen the secret isabsent, so this is safe to merge before the PAT exists — the check just stays inconclusive until then.