Skip to content

fix: port v9.0.36 upstream java changes - #363

Merged
twcclegg merged 1 commit into
mainfrom
updates2
Aug 2, 2026
Merged

fix: port v9.0.36 upstream java changes#363
twcclegg merged 1 commit into
mainfrom
updates2

Conversation

@twcclegg

@twcclegg twcclegg commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Changes

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

📊 Benchmark Results

Commit: 513c5cc · Full run · Windows windows-latest

PR branch 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.33158/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]    : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  .NET 10.0 : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Job=.NET 10.0  Runtime=.NET 10.0
Method PhoneNumberCount Mean Error StdDev Gen0 Gen1 Allocated
InputDigitPerKeystroke 1000 4.770 ms 0.0752 ms 0.0703 ms 242.1875 7.8125 3.9 MB 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.33158/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]     : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  Job-AMQORM : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Runtime=.NET 10.0  InvocationCount=1  IterationCount=20  
LaunchCount=1  RunStrategy=ColdStart  UnrollFactor=1  
WarmupCount=1
Method Mean Error StdDev Allocated
CreateInstance 330.6 μs 108.8 μs 125.3 μs 75.05 KB
CreateInstanceAndLoadAllRegions 9,009.0 μs 814.9 μs 938.4 μs 1575.89 KB
FirstRegionLookup 387.1 μs 166.1 μs 191.3 μs 80.11 KB 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.33158/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]    : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  .NET 10.0 : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Job=.NET 10.0  Runtime=.NET 10.0
Method PhoneNumberCount Mean Error StdDev Gen0 Allocated
ExtractPossibleNumber_CleanInput 1000 22.95 μs 0.209 μs 0.175 μs - -
ExtractPossibleNumber_WithLeadingJunk 1000 35.19 μs 0.517 μs 0.484 μs 2.8687 48360 B 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.33158/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]    : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  .NET 10.0 : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Job=.NET 10.0  Runtime=.NET 10.0
Method PhoneNumberCount Mean Error StdDev Gen0 Allocated
FindNumbers_Valid 100 157.1 μs 1.58 μs 1.48 μs 4.1504 69.93 KB
FindNumbers_StrictGrouping 100 351.4 μs 5.05 μs 4.47 μs 7.3242 123.3 KB 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.33158/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]    : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  .NET 10.0 : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Job=.NET 10.0  Runtime=.NET 10.0
Method PhoneNumberCount Mean Error StdDev Gen0 Allocated
ParseValidateAndFormatPhoneNumbers 1000 2.524 ms 0.0299 ms 0.0280 ms 35.1563 582.48 KB
ParseValidateAndFormatPhoneNumbers 10000 26.840 ms 0.5081 ms 1.3649 ms 343.7500 5818.97 KB
main branch 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32995/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]    : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  .NET 10.0 : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Job=.NET 10.0  Runtime=.NET 10.0
Method PhoneNumberCount Mean Error StdDev Gen0 Gen1 Allocated
InputDigitPerKeystroke 1000 4.681 ms 0.0506 ms 0.0474 ms 242.1875 7.8125 3.9 MB 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32995/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]     : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  Job-AMQORM : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Runtime=.NET 10.0  InvocationCount=1  IterationCount=20  
LaunchCount=1  RunStrategy=ColdStart  UnrollFactor=1  
WarmupCount=1
Method Mean Error StdDev Allocated
CreateInstance 316.4 μs 103.4 μs 119.1 μs 75.05 KB
CreateInstanceAndLoadAllRegions 8,664.4 μs 467.8 μs 538.8 μs 1575.89 KB
FirstRegionLookup 361.8 μs 129.7 μs 149.4 μs 80.11 KB 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32995/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]    : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  .NET 10.0 : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Job=.NET 10.0  Runtime=.NET 10.0
Method PhoneNumberCount Mean Error StdDev Gen0 Allocated
ExtractPossibleNumber_CleanInput 1000 22.73 μs 0.133 μs 0.124 μs - -
ExtractPossibleNumber_WithLeadingJunk 1000 35.91 μs 0.396 μs 0.351 μs 2.8687 48360 B 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32995/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]    : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  .NET 10.0 : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Job=.NET 10.0  Runtime=.NET 10.0
Method PhoneNumberCount Mean Error StdDev Gen0 Allocated
FindNumbers_Valid 100 157.2 μs 1.65 μs 1.54 μs 4.1504 69.93 KB
FindNumbers_StrictGrouping 100 336.8 μs 2.79 μs 2.61 μs 7.3242 123.3 KB 

BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32995/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.302
  [Host]    : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3
  .NET 10.0 : .NET 10.0.10 (10.0.10, 10.0.1026.32716), X64 RyuJIT x86-64-v3

Job=.NET 10.0  Runtime=.NET 10.0
Method PhoneNumberCount Mean Error StdDev Gen0 Allocated
ParseValidateAndFormatPhoneNumbers 1000 2.682 ms 0.0239 ms 0.0224 ms 35.1563 582.48 KB
ParseValidateAndFormatPhoneNumbers 10000 26.380 ms 0.3603 ms 0.3008 ms 343.7500 5818.97 KB

@codecov

codecov Bot commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.06%. Comparing base (4678853) to head (513c5cc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
csharp/PhoneNumbers/PhoneNumberUtil.cs 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files          40       40              
  Lines       52972    52975       +3     
  Branches     1126     1127       +1     
==========================================
+ Hits        51948    51949       +1     
- Misses        779      780       +1     
- Partials      245      246       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@twcclegg
twcclegg merged commit a442853 into main Aug 2, 2026
8 of 9 checks passed
@twcclegg
twcclegg deleted the updates2 branch August 2, 2026 00:35
This was referenced Aug 3, 2026
Open
Merged
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 11, 2026
Closed
Closed
Closed
Closed
Open
Closed
Closed
This was referenced Aug 18, 2026
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 27, 2026
Closed
Closed
Closed
Open
This was referenced Sep 1, 2026
Open
Open
Open
Open
Merged
Merged
Merged
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@twcclegg