feat: run code coverage on all prs and remove redundant github action - #250
Merged
twcclegg merged 1 commit intoMay 3, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 75.26% 75.26%
=======================================
Files 34 34
Lines 4422 4422
Branches 1001 1001
=======================================
Hits 3328 3328
Misses 885 885
Partials 209 209 ☔ View full report in Codecov by Sentry. |
twcclegg
added a commit
that referenced
this pull request
Aug 26, 2026
…Builder - Wrap the filename-derived second argument to Path.Combine in Path.GetFileName() in both output-path builders, so an unexpected path separator or rooted segment can never make Path.Combine silently drop the output directory (cs/path-combine, alerts #249/#250). - IsOutputUpToDate/IsGeocodingOutputUpToDate: both had a foreach loop that was really an Any() check (early-return on first match), and IsGeocodingOutputUpToDate had a separate foreach that was really a Select+Max fold. Replaced both with the LINQ equivalents (cs/linq/missed-where, alerts #13/#14; cs/linq/missed-select, alert #17). Left the top-level catch (Exception) in Main alone (cs/catch-of-all-exceptions, alert #275): it's the standard CLI entry-point idiom, logs to stderr and returns a non-zero exit code rather than swallowing anything. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes