docs: move pr template as its not being defaulted at the moment - #247
Merged
Conversation
2 tasks
pull Bot
pushed a commit
to LoadsAForks/libphonenumber-csharp
that referenced
this pull request
Aug 27, 2026
Closes out alert twcclegg#247 (NumberParseException.cs) and the broader gap left open in twcclegg#423, which deliberately skipped fixing it there because the bare-prose XML doc-comment style was assumed to be a pervasive, deliberate convention across ~31 files. Auditing the full csharp/PhoneNumbers, PhoneNumbers.MetadataBuilder, PhoneNumbers.Extensions and *.Test trees against origin/main shows nearly all of that convention has since been cleaned up elsewhere; only two files still had genuinely untagged prose: - NumberParseException.cs: the enum-level summary and the two ErrorType member comments (INVALID_COUNTRY_CODE, NOT_A_NUMBER) - PhoneNumberUtil.cs: the helper-initialiser comment above the extension regex constants Each bare block is wrapped in <summary>...</summary> with no change to the existing prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.