feat: update test projects to dotnet 8 - #239
Merged
wmundev merged 2 commits intoMar 31, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 83.39% 83.42% +0.02%
==========================================
Files 30 30
Lines 3499 3499
Branches 978 978
==========================================
+ Hits 2918 2919 +1
Misses 280 280
+ Partials 301 300 -1 ☔ View full report in Codecov by Sentry. |
Owner
|
We can add net8 whenever, but we want to keep net7 until at least May 14. |
Collaborator
Author
|
thanks Thomas, i'll restore dotnet 7 |
twcclegg
approved these changes
Mar 26, 2024
wmundev
marked this pull request as ready for review
March 31, 2024 04:09
twcclegg
added a commit
that referenced
this pull request
Aug 26, 2026
int.GetHashCode() returns the int itself, so XOR-ing Start directly is equivalent. Addresses CodeQL cs/useless-gethashcode-call (alert #239). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.