Closed
Conversation
twcclegg
added a commit
that referenced
this pull request
Aug 26, 2026
…erToTimeZonesMapper - numbers and MapTestData are never reassigned; marked readonly (cs/missed-readonly-modifier, alerts #271/#272). - ContainsKey+indexer double lookups replaced with TryGetValue (cs/inefficient-containskey, alerts #29/#30). - Three foreach loops that immediately mapped pn -> a per-number result and never touched pn again, rewritten with .Select() (cs/linq/missed-select, alerts #21-#23). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly packages net45 and netstandard1.0 .dlls into the .nupkg as well and listing the dependencies for each. This should better resolve #13
.nuspec can be removed completely is pack command is passed to build command.
Removes obsolete json files not used in VS2.0