Update metadata to v8.1.0 - #19
Merged
Merged
Conversation
twcclegg
added a commit
that referenced
this pull request
Aug 26, 2026
…ingBuilder - 9 spots created a match-iterator with manual .Dispose() after assertions that can throw on failure, leaking the enumerator on the failure path. Switched to using/using-var, in some cases splitting a method into scoped blocks so each of two sequential enumerators is still disposed promptly, matching the original ordering (cs/dispose-not-called-on-throw, alerts #361-#369). - FindMatchesInContexts: two foreach loops that immediately mapped context -> text and never used context again, rewritten as .Select() (cs/linq/missed-select, alerts #19/#20). - EnsureTermination: the per-iteration StringBuilder was write-only — appended to but never read, returned, or asserted against. The method's whole point (per its doc comment) is forcing full enumeration to confirm it terminates; the StringBuilder was dead weight, not an allocation to hoist out of the loop (cs/stringbuilder-creation-in-loop, alert #24). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the instructions in the read-me, with the exception of the protobuf step.