Fix ambiguous naming issues when consumed by VB.NET - #11
Merged
Conversation
Collaborator
|
Thanks for that, sorry it's taken so long to put in there - it's up on nuget.com now. |
twcclegg
added a commit
that referenced
this pull request
Aug 26, 2026
…ineGeocoder MetadataFilter.cs: - ComputeComplement's two filter-and-collect loops rewritten with .Where() (cs/linq/missed-where, alerts #10/#11). - ShouldDrop: TryGetValue instead of ContainsKey+indexer, avoiding the double dictionary lookup (cs/inefficient-containskey, alert #25). PhoneNumberOfflineGeocoder.cs: GetCountryNameForNumber's loop wasn't a pure filter (it early-returns once a *second* valid region turns up), so a naive .Where().ToList() would lose that short-circuit and evaluate IsValidNumberForRegion for every remaining region needlessly. .Where().Take(2) preserves the same lazy stopping point while still expressing the filter explicitly (cs/linq/missed-where, alert #12). Left PrefixFileReader.cs's LoadFileNamesFromManifestResources alone (cs/linq/missed-select, alert #15): it's a multi-step parse with three early-continue guard clauses and dictionary mutation, not a pure map; forcing it into .Select() would reduce clarity, not improve it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes Issue #10.
Protobuf generation introduces the issue despite my changes to the script calls. Additionally, the
cleanprotobuf.pyneeds some love since it failed on my local python engine (v3.0.1).Evidently I'm also adding a .NET .gitignore.