Two dimensional fix #225
Merged
Two dimensional fix #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added another test to test the max-media-query & two dimensional combo here. |
|
is there still something I have to do? |
MartijnCuppens
force-pushed
the
two-dimensional-fix
branch
from
974c8a8 to
5325c20
Compare
|
Nope, thanks. Just edited your commit message since you only referred to the Sass variable. I just need an approval from @XhmikosR to get this merged (Don't squash). |
MartijnCuppens
added a commit
to twbs/bootstrap
that referenced
this pull request
Apr 14, 2020
* Two dimensional fix - twbs/rfs#225
MartijnCuppens
added a commit
to twbs/bootstrap
that referenced
this pull request
Apr 14, 2020
* Two dimensional fix - twbs/rfs#225
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* Two dimensional fix - twbs/rfs#225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug where two-dimensional mode wouldn't correctly scale the desired values. tests are adjusted accrodingly. Yet there are still tests to be written.
Fixes #223
Not sure what happend to #224, but when I pushed to the branch, the branch closed.