Re-enable clean-css's advanced optimizations. #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pulled the branch down and run grunt. Unfortunately I'm still see the issue with Could I be running something that's out of date? I ran |
|
You shouldn't need to run It's possible that in your "node_modules" folder you have an older clean-css version like 2.1.7. |
The issue was fixed in v2.1.8.
|
Word. It was looking fine when I originally pulled down the branch. It wasn't until I ran |
|
So do you confirm everything is fine? I rebased the branch, just reset your local branch and remove the "node_modules" directory && npm install. |
|
Everything looks great. 🚢 |
XhmikosR
added a commit
that referenced
this pull request
Apr 1, 2014
Re-enable clean-css's advanced optimizations.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was fixed in v2.1.8.
/CC @connors: I don't see the issue anymore myself, but please confirm :)