Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default to scss variables #471

Merged
merged 1 commit into from
Apr 1, 2014
Merged

add default to scss variables #471

merged 1 commit into from
Apr 1, 2014

Conversation

christianseel
Copy link
Contributor

See issue #444

add default to scss variables
abc0203 
Doing so allows one to override default variables when writing custom SASS that imports Ratchet's SASS.
@cvrebert cvrebert added the css label Mar 9, 2014
@XhmikosR XhmikosR added this to the 2.0.2 milestone Mar 10, 2014
@XhmikosR
Copy link
Member

@connors: this seems to make sense.

@glebm: since SASS is more of your area of expertise, can you share your thoughts about this?

connors added a commit that referenced this pull request Apr 1, 2014
@connors
Merge pull request #471 from christianseel/patch-1
acdeb65 
add default to scss variables
@connors connors merged commit acdeb65 into twbs:master Apr 1, 2014
@connors connors mentioned this pull request Apr 1, 2014
Closed
@glebm
Copy link
Member

glebm commented Apr 1, 2014

@XhmikosR A bit of a late reply, but, yes, this is good stuff.

@XhmikosR
Copy link
Member

XhmikosR commented Apr 1, 2014

Better late than never. Thanks @glebm :)

@connors
Copy link
Collaborator

connors commented Apr 1, 2014

:) 👍

@XhmikosR XhmikosR mentioned this pull request Apr 1, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
5 participants
@christianseel @XhmikosR @glebm @connors @cvrebert