Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a sprite for device images #361

Merged
merged 1 commit into from
Mar 1, 2014
Merged

Use a sprite for device images #361

merged 1 commit into from
Mar 1, 2014

Conversation

connors
Copy link
Collaborator

@connors connors commented Mar 1, 2014

This will ensure smooth transitions when switching between platforms. Unfortunately we don't save a huge amount on space. The sprite is ~250k.

Addresses #313.

@connors connors added the docs label Mar 1, 2014
@connors connors added this to the 2.0.1 milestone Mar 1, 2014
@connors
Copy link
Collaborator Author

connors commented Mar 1, 2014

Also, the old images were ~100k each. So overall it's a win. 👍

mdo added a commit that referenced this pull request Mar 1, 2014
Use a sprite for device images
@mdo mdo merged commit 317e70b into master Mar 1, 2014
@mdo mdo deleted the device-sprite branch March 1, 2014 22:42
@mdo mdo mentioned this pull request Mar 1, 2014
@XhmikosR
Copy link
Member

XhmikosR commented Mar 2, 2014

@connors: they weren't 100KB each, I had compressed them losslessly ;)

@XhmikosR
Copy link
Member

XhmikosR commented Mar 2, 2014

@connors: BTW, with Firefox the sprite doesn't work on desktop since you used the non-standard background-position-x.

2014-03-02_13-53-53

I fixed it in b6680e0

@connors
Copy link
Collaborator Author

connors commented Mar 2, 2014

@XhmikosR Thanks dude!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants