Apply gradient stripe @color parameter #9968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -496,7 +496,7 @@ | |||
| .progress-bar-variant(@color) { | |||
| background-color: @color; | |||
| .progress-striped & { | |||
| #gradient > .striped(@color); | |||
There was a problem hiding this comment.
Remove the @color parameter so the striped color does not match the background-color. It might be a good idea to provide a second parameter to the progress-bar-varient() mixin to control the striped color. Example below.
.progress-bar-varient(@background-color; @striped-color) {
background-color: @background-color;
.progress-striped & {
#gradient > .striped(@striped-color);
}
}
mdo
added a commit
that referenced
this pull request
Sep 6, 2013
Apply gradient stripe @color parameter
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
Apply gradient stripe @color parameter
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
Apply gradient stripe @color parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @color parameter for the #gradient > .striped() mixin is not being used. Currently, the striped color is hard coded to be a transparent white and not the #555 color value set as the default @color parameter.