Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic keyboard accessibility CSS tweaks #6441

Merged
merged 6 commits into from
Feb 6, 2013
Merged

Basic keyboard accessibility CSS tweaks #6441

merged 6 commits into from
Feb 6, 2013

Commits on Jan 2, 2013

  1. Basic keyboard accessibility CSS tweaks

    Mostly doubling-up :hover styles to also cover :focus, as a first step
    to making the framework more keyboard-friendly.
    Additionally, fixed two small markup issues in the docs/examples to
    make the "Learn more" large primary button-styled links
    keyboard-focusable (as without href they're treated as non-tabable
    anchors).
    patrickhlauke committed Jan 2, 2013
    Configuration menu
    Copy the full SHA
    848ca6e View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2013

  1. Cleaned up dirty CSS

    Used recess rather than less
    patrickhlauke committed Jan 12, 2013
    Configuration menu
    Copy the full SHA
    77c68e4 View commit details
    Browse the repository at this point in the history
  2. Keyboard accessibility in documentation

    Removed unnecessary (?) and harmful (from a keyboard access point of
    view) tabindex=-1 in the documentation examples.
    patrickhlauke committed Jan 12, 2013
    Configuration menu
    Copy the full SHA
    a809daf View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2013

  1. Revert "Keyboard accessibility in documentation"

    This reverts commit a809daf.
    patrickhlauke committed Jan 15, 2013
    Configuration menu
    Copy the full SHA
    4503ad7 View commit details
    Browse the repository at this point in the history
  2. Leave tabindex=-1 alone

    It seems that, as misguided as I personally think it is, ARIA does
    indeed want dropdown menus not to behave as regular keyboard users
    expect them, killing TAB/SHIFT+TAB in favor of cursor keys. Fair
    enough, the issue I have is then with ARIA, not with bootstrap. I would
    sugges thought that if you really do want to follow ARIA consistently,
    *any* navigation bar should also become an ARIA menu, further making it
    impossible for keyboard users to use TAB/SHIFT+TAB to navigate through
    it, and that these changes should be reflected in the bootstrap
    examples as well...
    patrickhlauke committed Jan 15, 2013
    Configuration menu
    Copy the full SHA
    370fa45 View commit details
    Browse the repository at this point in the history
  3. Revert "Leave tabindex=-1 alone"

    This reverts commit 370fa45.
    patrickhlauke committed Jan 15, 2013
    Configuration menu
    Copy the full SHA
    c553290 View commit details
    Browse the repository at this point in the history