Two Makefile improvements #6435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The echo command does not understand the -n argument on Mac OS X. This is due to the fact that: - Makefile calls /bin/sh to execute a command - in Mac OS X, /bin/sh is a link to bash - in Mac OS X, bash is compiled with --enable-strict-posix-default Therefore, the echo command does not have the -n argument. printf on the other hand is a builtin function that works well on Mac OS X and Linux.
The change introduced in 5bd8cdc was: - partial, as not all the command were translated - preventing the use of a global npm installation
A user can use the following command to determine where to copy the resulting css file:
$ BOOTSTRAP=<my-path> make
|
Unfortunately I have to close this since we've changed the makefile in #6346. Check out those changes and please resubmit (against 3.0.0-wip, as we're merging 2.3.0-wip in regularly) once again. Sorry for the back and forth, but I'd totally dig having the make statements split if possible. Would make things feel more accurate. Thanks! |
Closed
|
Can you please take a look at #6576? I have made the changes. It works on Linux and Mac OS. It has incorporated the changes made in 2.3 and cleaned up the hard coded paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.