Skip to content

Conversation

gurdiga
Copy link
Contributor

@gurdiga gurdiga commented Mar 20, 2025

Description

This is a lil change in the Supported content section.

I haven’t been able to find any other references to the .navbar-scroll CSS class, and it seems to me that the author meant to say .navbar-nav-scroll instead, because this other class is mentioned in the Scrolling section.

Motivation & Context

I was reading the docs and got a lil confused by the (seeming) mismatch.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

I haven’t been able to find any other references to the `.navbar-scroll` CSS class, and it seems to me that the author meant to say `.navbar-nav-scroll` instead, because this other class is mentioned in the `Scrolling` section [1].

[1] https://getbootstrap.com/docs/5.3/components/navbar/#scrolling
@github-project-automation github-project-automation bot moved this to To do in v5.3.4 Mar 21, 2025
@julien-deramond julien-deramond moved this from To do to Ready to merge in v5.3.4 Mar 21, 2025
@julien-deramond julien-deramond self-requested a review March 21, 2025 19:58
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix 🙏

@julien-deramond julien-deramond merged commit 5c75fda into twbs:main Mar 21, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in v5.3.4 Mar 21, 2025
madbob pushed a commit to madbob/bootstrap that referenced this pull request Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants