Docs: drop unused .bi-exclamation-triangle-fill class
#39815
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should actually keep the classes and IDs in the icons so that we are close to the upstream code for easier copy-paste. We just need to be consistent from now on and update the sprite and everything from icons to be as close as the upstream code. |
|
I leave this to the two of you :). Doesn't matter to me. |
mdo
force-pushed
the
main-jd-drop-useless-bi-exclamation-triangle-fill
branch
from
65ad225 to
8491140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While checking the several docs ongoing PRs, I stumbled upon this
.bi-exclamation-triangle-fillclass that is useless.Feel free to close the PR if it's already handled in another PR.
Note: I've checked the presence of other
.bi-*classes and it was the only one