Skip to content

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 12, 2024

This way the dimensions are not hardcoded

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR added the docs label Mar 12, 2024
@XhmikosR XhmikosR force-pushed the xmr/docs-imgconfig branch 2 times, most recently from 4dff889 to f3e40fd Compare March 13, 2024 06:09
@XhmikosR XhmikosR changed the title docs: switch to imageConfig docs: add a new partial for responsive images and use imageConfig Mar 13, 2024
@XhmikosR XhmikosR marked this pull request as ready for review March 19, 2024 09:34
@XhmikosR XhmikosR merged commit 4093ed3 into main Apr 1, 2024
@XhmikosR XhmikosR deleted the xmr/docs-imgconfig branch April 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant