Skip to content

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 9, 2024

Description

This PR removes data-bs-scroll="true" from the documentation navbar. It had been introduced in #36307 to fix #36306. This issue can't happen anymore since the search input is no more present in the offcanvas displayed at small breakpoints.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review March 9, 2024 08:54
@XhmikosR XhmikosR self-requested a review March 9, 2024 16:22
@XhmikosR XhmikosR merged commit 6ce0c62 into main Mar 11, 2024
@XhmikosR XhmikosR deleted the main-jd-drop-data-bs-scroll-from-docs-navbar branch March 11, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Impossible to search on mobile with new DocSearch v3
2 participants