Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sass compilation breaking change in v5.3 #39380

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Fix Sass compilation breaking change in v5.3 #39380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
570cd24
Fix Sass compilation breaking change in v5.3
julien-deramond Nov 8, 2023
b3845cc
Simplified test and renaming
julien-deramond Nov 13, 2023
3c29b24
Merge branch 'main' into main-jd-fix-sass-compilation-breaking-change
julien-deramond Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1745,3 +1745,5 @@ $kbd-bg: var(--#{$prefix}body-color) !default;
$nested-kbd-font-weight: null !default; // Deprecated in v5.2.0, removing in v6

$pre-color: null !default;

@import "variables-dark"; // TODO: can be removed safely in v6, only here to avoid breaking changes in v5.3
7 changes: 7 additions & 0 deletions scss/tests/mixins/_auto-import-of-variables-dark.test.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// TODO: this file can be removed safely in v6 when `@import "variables-dark"` will be removed at the end of _variables.scss

@import "../../functions";
@import "../../variables";
// Voluntarily not importing _variables-dark.scss
@import "../../maps";
@import "../../mixins";