-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize disabled nav links CSS rules #38774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
I looked at this purely for the #38765 scenario, and this fix here works great. not had a chance to go through all possible complex variations |
mdo
approved these changes
Jun 25, 2023
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
Co-authored-by: Patrick H. Lauke <[email protected]>
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced Sep 18, 2024
This was referenced Sep 28, 2024
This was referenced Sep 30, 2024
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most of the time, our
.nav-link
s are really links and don't need:disabled
rules. However, we provide JavaScript examples (e.g. with.nav-tabs
) where we use<button>
s that can need:disabled
rules.This PR suggest a kind of defensive approach where the disabled state is defined globally for all
.nav-link
s using.disabled
and:disabled
selectors.It allows us to remove the other rules defining the colors.
Please double-check different complex use cases to avoid any regressions since the documentation does not reflect all possibilities.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Linked to #38765 but doesn't take into account #38765 (comment)