Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix data-bs-theme="dark" on component carousel itself #38209

Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix data-bs-theme="dark" on component carousel itself #38209

merged 1 commit into from
Mar 10, 2023

Conversation

jonnysp
Copy link
Contributor

@jonnysp jonnysp commented Mar 10, 2023 •
edited
Loading

Description

the description says

"Instead of adding .carousel-dark, set data-bs-theme="dark" on the root element, a parent wrapper, or the component itself. "

but it does not work on the element itself

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@jonnysp
Update _carousel.scss
7ab9cb7 
fix  data-bs-theme="dark" on component itself
@jonnysp jonnysp requested a review from a team as a code owner March 10, 2023 11:02
@mdo
Copy link
Member

mdo commented Mar 10, 2023

Thanks for this! Also noting that we may need to do this on other components.

@mdo mdo merged commit 9c0b2be into twbs:main Mar 10, 2023
@jonnysp jonnysp deleted the carousel-dark branch March 11, 2023 08:41
@jonnysp
Copy link
Contributor Author

jonnysp commented Mar 11, 2023

that can be, at modal and card the text color are not taken over, in addition a workaround #38212

@vinc vinc mentioned this pull request Mar 24, 2023
Closed
3 tasks
@malberts malberts mentioned this pull request Mar 25, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnysp @mdo