-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 - Remove confusing unnecessary id/aria-labelledby for dropdown menus #36491
v4 - Remove confusing unnecessary id/aria-labelledby for dropdown menus #36491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've maybe spotted one we forgot in the original PR (and here). In site/layouts/partials/docs-navbar.html:
<div class="dropdown-menu dropdown-menu-md-right" aria-labelledby="bd-versions"> |
@julien-deramond yeah, i saw that one, but that's our own use of it on the docs page. i still think it's a nice-to-have little addition - doesn't make a huge accessibility difference, but gives a bit more context. just not something important enough to warrant inclusion in every example we provide (where it then confused people thinking they needed to do it for it to work) |
@julien-deramond having said that, I just checked how it announces in chrome/nvda ... and it didn't announce the label for the list at all for some reason. so yeah, might as well remove it... |
v4 port of #36487