Skip to content

Accept argument of different types in the getInstance method #34333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 29, 2021
Merged

Accept argument of different types in the getInstance method #34333

merged 8 commits into from
Jun 29, 2021

Conversation

jeremyvii
Copy link
Contributor

This PR updates BaseComponent.getInstance(element) to resolve multiple data types to a component, by passing element to getElements() before attempting to retrieve the component.

Closes #34310.

@jeremyvii jeremyvii requested a review from a team as a code owner June 22, 2021 17:27
@GeoSot GeoSot requested a review from rohit2sharma95 June 22, 2021 19:50
rohit2sharma95
rohit2sharma95 reviewed Jun 23, 2021
View reviewed changes
Copy link
Contributor

@rohit2sharma95 rohit2sharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to update the documentation for this method (and for getOrCreateInstance as well) 🙂

@rohit2sharma95 rohit2sharma95 changed the title Resolve multiple data types to a component Accept argument of different types in the getInstance method Jun 23, 2021
rohit2sharma95
rohit2sharma95 reviewed Jun 24, 2021
View reviewed changes
@jeremyvii jeremyvii requested a review from rohit2sharma95 June 24, 2021 17:03
@XhmikosR XhmikosR merged commit d314466 into twbs:main Jun 29, 2021
@jeremyvii jeremyvii deleted the resolve-multiple-data-types branch June 29, 2021 15:13
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
@jeremyvii @marvin-hinkley-vortx
Accept argument of different types in the getInstance method (twbs#…
8816717 
…34333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoSot GeoSot GeoSot approved these changes

@rohit2sharma95 rohit2sharma95 Awaiting requested review from rohit2sharma95

Assignees
No one assigned
Labels
feature js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Components getInstance should be able to resolve string selectors and jQuery objects as the componnent constructor
4 participants
@jeremyvii @GeoSot @rohit2sharma95 @XhmikosR