Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aria-haspopup from dropdowns #33624

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Remove aria-haspopup from dropdowns #33624

merged 1 commit into from
Apr 15, 2021

Commits on Apr 13, 2021

  1. Remove aria-haspopup from dropdowns 

    `aria-haspopup="true"` is really intended to signal that an ARIA `menu` will be opened on activation. as a result, some assistive technologies will announce controls with `aria-haspopup="true"` as a menu or menu item (e.g. JAWS and NVDA).
In addition, `aria-haspopup` seems to trigger a bug in Edge/Narrator where the `aria-expanded` state is not correctly announced at the moment when `aria-haspopup` is present.
This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01
    @patrickhlauke
    patrickhlauke committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    3b4e87c View commit details
    Browse the repository at this point in the history