Skip to content

Allow individual grid classes to override .row-cols #33621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 3, 2021
Merged

Allow individual grid classes to override .row-cols #33621

merged 10 commits into from
Jun 3, 2021

Conversation

lacutah
Copy link
Contributor

@lacutah lacutah commented Apr 13, 2021 •
edited by mdo
Loading

closes #33530

@lacutah lacutah requested a review from a team as a code owner April 13, 2021 20:11
@lacutah lacutah mentioned this pull request Apr 13, 2021
Closed
@mdo
Copy link
Member

mdo commented Apr 17, 2021

As far as I can tell, I don't think this fixes the issue? https://codepen.io/emdeoh/pen/MWJBPBG?editors=1100

@lacutah
Copy link
Contributor Author

lacutah commented Apr 18, 2021 •
edited
Loading

As far as I can tell, I don't think this fixes the issue? https://codepen.io/emdeoh/pen/MWJBPBG?editors=1100

That pen/editor isn't using the updated CSS this fix addresses? I updated: https://codepen.io/Lacutah/pen/xxgaxQV

Discussion tangentially related to this PR moved to #33831

@ffoodd
Copy link
Member

ffoodd commented May 4, 2021

Made two separate pens to help review:

  1. Using alpha3: https://codepen.io/ffoodd/pen/WNpepvY
  2. Using this PR: https://codepen.io/ffoodd/pen/PopYpZR

So I can confirm it fixes the issue.
@lacutah Please be patient as we're all volunteers here; and make sure to provide an easy way to check what you did :) Some PR get stuck because they require too much time to review.

@lacutah
Copy link
Contributor Author

lacutah commented May 5, 2021

@ffoodd, - totally get it, honestly not trying to cause headache and am incredibly appreciative of all the hard work that happens! Projects like this make my job easier! Maybe I don't know where to look, but I have no way to see what's going on with all the volunteers nor an expectation of what a "normal" timeline is like on this project - all I knew is the (two) bugs / requests were hot for a minute, then crickets - so I "pinged" it LOL.

I look forward to helping out on other issues in the future, and if I can make it easier for you (all) by putting up codepens demonstrating the fixes, then I'm very happy to do so! We all benefit from open source every day - I think it's pawsome to be able to "give back" as well when I have the bandwidth!

XXX Would you like me to create a separate bug or discussion regarding the potentially better implementation mentioned in my very long comment above? I don't want to do the work if it's not wanted / going in the wrong direction.

@ffoodd
Copy link
Member

ffoodd commented May 5, 2021

A discussion is appropriate I guess 👌

@XhmikosR XhmikosR changed the title Row-columns-breakpoint inconsistency fix closes #33530 Row-columns-breakpoint inconsistency fix May 13, 2021
@XhmikosR XhmikosR changed the title Row-columns-breakpoint inconsistency fix Fix row-columns-breakpoint inconsistency May 13, 2021
@XhmikosR XhmikosR requested a review from mdo May 14, 2021 11:22
@mdo
Copy link
Member

mdo commented Jun 3, 2021

Made two separate pens to help review:

  1. Using alpha3: https://codepen.io/ffoodd/pen/WNpepvY
  2. Using this PR: https://codepen.io/ffoodd/pen/PopYpZR

These two examples are amazing, super helpful in showing this bug. I'll likely want to include them in our blog post for v5.0.2!

@ffoodd
Copy link
Member

ffoodd commented Jun 3, 2021 •
edited by XhmikosR
Loading

I'll likely want to include them in our blog post for v5.0.2!

Make sure to credit @lacutah for the initial pen :)

@XhmikosR XhmikosR changed the title Fix row-columns-breakpoint inconsistency Allow individual grid classes to override .row-cols Jun 3, 2021
@XhmikosR XhmikosR merged commit f2b47e1 into twbs:main Jun 3, 2021
@lacutah lacutah deleted the RowColConsistency branch June 3, 2021 16:23
@ffoodd ffoodd mentioned this pull request Jun 29, 2021
Closed
mdo added a commit that referenced this pull request Jul 28, 2021
@mdo
Revert "Allow individual grid classes to override .row-cols (#33621)"
7dddae6 
This reverts commit f2b47e1.
@mdo mdo mentioned this pull request Jul 28, 2021
Merged
XhmikosR pushed a commit that referenced this pull request Jul 29, 2021
@mdo
Revert "Allow individual grid classes to override .row-cols (#33621)…
906a990 
…" (#34612)

This reverts commit f2b47e1.
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
@lacutah @marvin-hinkley-vortx
Allow individual grid classes to override .row-cols (twbs#33621)
8dc3bb4
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
@mdo @marvin-hinkley-vortx
Revert "Allow individual grid classes to override .row-cols (twbs#3…
3b5d70b 
…3621)" (twbs#34612)

This reverts commit f2b47e1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column CSS doesn't override row column default css when row-cols-[breakpoint]-[x] is used.
5 participants
@lacutah @mdo @ffoodd @XhmikosR @alpadev