Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown escape propagation #33479

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Fix dropdown escape propagation #33479

merged 5 commits into from
Apr 1, 2021

Commits on Mar 30, 2021

  1. refactor: extract the menu item selection logic into its own function 

    this reduces the complexity of the dataApiKeydownHandler to get rid of the eslint warning
    @alpadev @GeoSot
    alpadev authored and GeoSot committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    f307fdd View commit details
    Browse the repository at this point in the history

  2. test: add test case for dropdown escape key propagation

    @alpadev @GeoSot
    alpadev authored and GeoSot committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0eaa413 View commit details
    Browse the repository at this point in the history

  3. fix: escape key should not be handled when the dropdown is closed 

    see twbs#33465
    @alpadev @GeoSot
    alpadev authored and GeoSot committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    04022c9 View commit details
    Browse the repository at this point in the history

  4. refactor: changed getButton to getToggleButton 

    requested by rohit2sharma95 - twbs#33479 (comment)
    @alpadev @GeoSot
    alpadev authored and GeoSot committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    3f658e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Merge branch 'main' into fix-dropdown-escape-propagation

    @XhmikosR
    XhmikosR authored Apr 1, 2021
    Configuration menu
    Copy the full SHA
    8326bb5 View commit details
    Browse the repository at this point in the history