Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust feedback icon position and padding for select.form-control #33206

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Feb 26, 2021

Fixes #31219.

Doesn't add any new variables for now, instead doing the operations inline. Unsure if it's worth really adding a variable for this anyway, but if so, we can do it in a v4.7.x release.


Chrome

Screen Shot 2021-02-25 at 7 20 25 PM

Safari

Screen Shot 2021-02-25 at 7 20 17 PM

Firefox

Screen Shot 2021-02-25 at 7 20 32 PM

@mdo mdo requested a review from a team as a code owner February 26, 2021 03:23
@XhmikosR
Copy link
Member

If we backport #33131 I think we can make the next release a 4.7.0 release? So, I'd say you could add a new variable otherwise better add a TODO so that we don't forget about it.

@mdo mdo merged commit 7365592 into v4-dev Mar 11, 2021
@mdo mdo deleted the v4-select-feedback-icon-position branch March 11, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants